Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Stabilize twig template usage #241

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

SMillerDev
Copy link
Owner

No description provided.

@SMillerDev SMillerDev force-pushed the feat/stabilize_twig_templates branch 2 times, most recently from 0589b5d to dc2673a Compare April 20, 2021 18:50
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
@SMillerDev SMillerDev force-pushed the feat/stabilize_twig_templates branch from dc2673a to 35c3e1d Compare April 20, 2021 19:02
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #241 (35c3e1d) into master (ce973b1) will decrease coverage by 9.14%.
The diff coverage is 59.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #241      +/-   ##
============================================
- Coverage     87.88%   78.73%   -9.15%     
- Complexity      333      334       +1     
============================================
  Files            23       23              
  Lines           809      823      +14     
============================================
- Hits            711      648      -63     
- Misses           98      175      +77     
Impacted Files Coverage Δ Complexity Δ
.../PHPDraft/Model/Elements/ArrayStructureElement.php 81.81% <0.00%> (ø) 7.00 <0.00> (ø)
src/PHPDraft/Out/TwigFactory.php 0.00% <0.00%> (-58.98%) 3.00 <0.00> (+1.00) ⬇️
.../PHPDraft/Model/Elements/BasicStructureElement.php 54.38% <66.66%> (ø) 24.00 <9.00> (ø)
src/PHPDraft/Model/HTTPResponse.php 87.75% <90.47%> (-3.36%) 25.00 <10.00> (+2.00) ⬇️
...c/PHPDraft/Model/Elements/EnumStructureElement.php 89.47% <100.00%> (ø) 14.00 <0.00> (ø)
...PHPDraft/Model/Elements/ObjectStructureElement.php 93.90% <100.00%> (+0.96%) 45.00 <1.00> (-2.00) ⬆️
src/PHPDraft/Out/TemplateRenderer.php 62.38% <0.00%> (-36.70%) 33.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff63909...35c3e1d. Read the comment docs.

@SMillerDev SMillerDev merged commit 96625a2 into master Apr 20, 2021
@SMillerDev SMillerDev deleted the feat/stabilize_twig_templates branch April 20, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant