Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/calendar integration #72

Merged
merged 24 commits into from
Feb 4, 2025
Merged

Conversation

briantkatch
Copy link
Contributor

@briantkatch briantkatch commented Jan 30, 2025

🛠 Proposed Changes:

Added logic for calendar integration.

🔗 Related Issue(s):

@briantkatch
Copy link
Contributor Author

@NathanGrenier @Jpuntul there are some lint issues that git blame to you. Could you take a look? This may be the result of a merge conflict.

@NathanGrenier
Copy link
Contributor

@NathanGrenier @Jpuntul there are some lint issues that git blame to you. Could you take a look? This may be the result of a merge conflict.

It's just some lint issues. You can fix most by running rps lint fix.

image

@briantkatch
Copy link
Contributor Author

That seems to fix the issues in homepage, but there's still issues in main.dart that come back to you @NathanGrenier. Could you take a look?

references to non existing page
Copy link
Contributor

@NathanGrenier NathanGrenier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else seems good.

@NathanGrenier
Copy link
Contributor

I ran flutter run, but don't see any changes. Are you using the new page in the app?

Also, make sure to link to the issue this PR is resolving in the PR description.

@briantkatch
Copy link
Contributor Author

Resolves #53. I thought we were using zenhub.

I only added the repository, and I don't use it in the app. But it can be tested with console logs.

@NathanGrenier
Copy link
Contributor

Resolves #53. I thought we were using zenhub.

ZenHub uses github issues, so by referencing the issue in the PR the ticket will be closed once the PR is merged.

@MeSumo
Copy link
Collaborator

MeSumo commented Feb 1, 2025

@nathanial-hwong I merged with the develop branch and restructured the folders to match what you requested. Code works this way, but is this the structure you had it mind including the other files?

@Niravanaa
Copy link
Contributor

image

I don't seem to be able to access my Android's calendar even if the permissions have been indicated in the manifest file and in the simulated device's system settings.

I've been looking into it for the past 4 hours but to no avail.

@briantkatch
Copy link
Contributor Author

image

I don't seem to be able to access my Android's calendar even if the permissions have been indicated in the manifest file and in the simulated device's system settings.

I've been looking into it for the past 4 hours but to no avail.

@Niravanaa what troubleshooting steps have you already tried? Did you do a flutter clean and flutter pub get?

@Niravanaa
Copy link
Contributor

@briantkatch Yes, I've tried flutter clean and flutter pub get, this did not work.

Most discussion threads having this sort of error were able to resolve the issue doing that, but that did not work on my end.

I've signed into Google Calendar with an account, so the app itself shouldn't be an issue.

I want to check if I'm the only one having this issue, @MeSumo are you able to reproduce this with a simulated/real Android device?

@MeSumo
Copy link
Collaborator

MeSumo commented Feb 2, 2025

I want to check if I'm the only one having this issue, @MeSumo are you able to reproduce this with a simulated/real Android device?

@Niravanaa I tested with a physical android device after doing flutter clean and flutter pub get. I get the same issue as seen below. Will try to look into it a bit as well.
image

@Niravanaa
Copy link
Contributor

Fixed up the pubspec.yaml file and was able to test some methods of the calendar repo, specifically checking calendar permissions, and displaying events from the pre-existing calendars available on the device.

image
image
image

Niravanaa
Niravanaa previously approved these changes Feb 3, 2025
Copy link
Contributor

@Niravanaa Niravanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works on Android and iOS

@Niravanaa Niravanaa requested a review from MeSumo February 3, 2025 21:56
Copy link
Contributor

@Niravanaa Niravanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@briantkatch
Copy link
Contributor Author

@MeSumo or @CarciDev LGTM, need a review from one of you

Copy link
Contributor

@Niravanaa Niravanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! LGTM.

Copy link
Collaborator

@MeSumo MeSumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on physical Android device (v15)

After adding a temporary button and calling the getUserCalendars() method for testing purposes, the application successfully requested Calendar permissions and outputted instances of UserCalendar once accepted.

Screenshot_2025-02-04-08-20-33-31_ab1359306de43320f9557c797b1c4be5

@MeSumo MeSumo merged commit cd4f95d into develop Feb 4, 2025
4 checks passed
@MeSumo MeSumo deleted the feature/calendar-integration branch February 4, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants