Fix missing key in message sends by Producer issue #700
Conversation
lib/baseProducer.js
Outdated
| @@ -134,7 +134,7 @@ BaseProducer.prototype.buildPayloads = function (payloads, topicMetadata) { | |||
| if (message instanceof KeyedMessage) { | |||
| return message; | |||
| } | |||
| return new Message(0, 0, '', message); | |||
| return new Message(0, 0, p.key || '', message); | |||
There was a problem hiding this comment.
what happens if the key is number 0? Would it be better to check if key != null and then use the key otherwise empty string?
There was a problem hiding this comment.
hmm looks like that may not make it down the line checkout https://github.com/SOHU-Co/kafka-node/blob/master/lib/protocol/protocol.js#L412
There was a problem hiding this comment.
Yes, even if I give a pass here, it would still having problem at encodeMessage(). So, I guess the key must be type of String, right? In such case, what if p.key = true? I think the boolean value will cause some problem, I think we should use _.isEmpty(p.key) to check it.
fixes SOHU-Co#699 Signed-off-by: Tao Wang <twang2218@gmail.com>
|
I updated the PR, now |
|
Fixed in #704 and published as 2.0.0. Thanks for your help. |
fixes #699
Signed-off-by: Tao Wang twang2218@gmail.com