Implement more supernodes for incrementing/decrementing #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- generalize existing nodes to work with arbitrary values, support decrementing, and match new naming scheme All nodes now supported: - IncExpWithValue: adds or subtracts a constant value to/from a subexpression - [Uninit]IncFieldWithValueNode: increment or decrement a field by a constant value - [Uninit]IncFieldWithExpNode: increment or decrement a field with a value from a subexpression - Inc[Non]LocalVarWithExpNode: increment or decrement a local with a value from a subexpression - Inc[Non]LocalVarWithValueNode: increment or decrement a local by a constant value - SomSom's parser also has `text := text + self currentChar.` where `text` is a field in the lexer, this is supported too
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds various supernodes and generalizes existing nodes to work with arbitrary values, support decrementing, and match new naming scheme.
All nodes now supported:
Since SomSom's parser also has
text := text + self currentChar.wheretextis a field in the lexer, this is supported too.First implemented as part of: #185