Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[platform/cel]: Add function confirmation #143

Merged
merged 1 commit into from
Apr 10, 2020
Merged

[platform/cel]: Add function confirmation #143

merged 1 commit into from
Apr 10, 2020

Conversation

mudsut4ke
Copy link

- What I did

  • Update platform module cel
    • add confirmation for bmc-exec command
    • add confirmation for power command

@mudsut4ke mudsut4ke requested a review from xwang9 March 25, 2020 06:49
@mudsut4ke mudsut4ke self-assigned this Mar 25, 2020
xwang9
xwang9 approved these changes Apr 10, 2020
View reviewed changes
Copy link

@xwang9 xwang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's ok for me

@mudsut4ke mudsut4ke requested a review from xwang9 April 10, 2020 09:50
xwang9
xwang9 approved these changes Apr 10, 2020
View reviewed changes
Copy link

@xwang9 xwang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is ok for me

@mudsut4ke mudsut4ke requested a review from pphuchar April 10, 2020 10:32
pphuchar
pphuchar approved these changes Apr 10, 2020
View reviewed changes
Copy link
Collaborator

@pphuchar pphuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only update the platform submodule, Approved.

@mudsut4ke mudsut4ke merged commit 03edef0 into SONIC-DEV:201811_cel Apr 10, 2020
mudsut4ke pushed a commit that referenced this pull request Jan 25, 2021
@jleveque
[sonic-platform-common] Update submodule (sonic-net#5953)
6c4092d 
Commits include:

* src/sonic-platform-common e4883e5...5db8c84 (1):
  > [sonic-platform-common] Fix name error and import error  (#143)
mudsut4ke pushed a commit that referenced this pull request Jan 25, 2021
@jleveque
[sonic-platform-daemons] Update submodule (sonic-net#6535)
4a8e513 
Submodule changes to be committed:

* src/sonic-platform-daemons 81318f7...e72f6cd (3):
  > [ledd] Minor refactor; add unit tests (#143)
  > [thermalctld] Report unit test coverage (#141)
  > [psud] Increase unit test coverage (#140)
jerseyang pushed a commit that referenced this pull request Jun 4, 2021
@jleveque @lguohan
[sonic-platform-daemons] Update submodule (sonic-net#6535)
50912ad 
Submodule changes to be committed:

* src/sonic-platform-daemons 81318f7...e72f6cd (3):
  > [ledd] Minor refactor; add unit tests (#143)
  > [thermalctld] Report unit test coverage (#141)
  > [psud] Increase unit test coverage (#140)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pphuchar pphuchar pphuchar approved these changes

@xwang9 xwang9 xwang9 approved these changes

Assignees

@mudsut4ke mudsut4ke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mudsut4ke @xwang9 @pphuchar