-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fanctrl] Fix fanctrl crash when system thermal direction is unknown #151
[fanctrl] Fix fanctrl crash when system thermal direction is unknown #151
Conversation
[platform/fanctrl] Fix daemon crash when thermal direction is unknown. *Fix pointer uninitialized when thermal direction is unknown. *If thermal direction is unknown, set fan speed to 100% and exit program. *Update new F2B system and fans Part-Number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good, Can you attach a test log when service work as normal ?
Still waiting for a new FANs/PSUs FRU image... |
Normal running with F2B fans and a psu.
|
* src/sonic-snmpagent 89b7b2c...c702a57 (7): > Revert "[rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (#133)" (#151) > Update transceiver info DB key names (#146) > Fix LGTM reported alert of PR#141 (#142) > [Namespace] Fix interfaces counters in InterfacesMIB RFC 2863 (#141) > [Namespace]: Fix SNMP AgentX socket connection timeout when using Namespace.get_all() (#140) > [rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (#133) > Fix undefined variable and warning message (#134) * src/sonic-py-swsssdk a83366e...2df4f40 (3): > Allowing TCP connections with namespace as well. (#81) > [port_util] add get_rif_port_map, get_vlan_interface_oid_map (#78) > Updates to the namespace API's for test_moduleLoad.py (#77) Note that sonic-snmpagent submodule update is dependent upon sonic-py-swsssdk update, so updating both submodules in this PR.
…ic-net#6124) This PR updates the submodule sonic-platform-common, sonic-platform-daemons For sonic-platform-common update following commits are added a8823a3 [sonic_y_cable] add check_mux_direction api for y_cable (#151) 7c0301d Modular Chassis - APIs for midplane monitoring (#148) 6f7d8a0 Fix some LGTM alerts; Add LGTM badges to README.md (#146) for sonic-platform-daemons update following commits are added 73e6ddd [xcvrd] replace check_active_linked_tor_side api to check_mux_direction (#131) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This PR includes the following commit in sonic-platform-daemons 068bccc [xcvrd] Store mux_cable telemetry data in State DB (#148) 93cac0a [ci]: download from sonic-buildimage.vs artifact (#152) d651e9b [GitHub] Add pull request template (#151) bd7830b [pcied] Remove unnecessary message and move the configuration path (#144) 9080fda [ci] Call pip2/3 using sudo (#150) de60784 [ci] Test and build packages using Azure Pipelines (#149) 8bf0fd1 [ledd] Refactor to allow for more thorough unit testing; Increase unit test coverage (#147) 26bdc9e Set up CI with Azure Pipelines 1fcaa57 [pcied] Add PCIe AER stats collection (#100) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This PR includes the following commit in sonic-platform-daemons 068bccc [xcvrd] Store mux_cable telemetry data in State DB (#148) 93cac0a [ci]: download from sonic-buildimage.vs artifact (#152) d651e9b [GitHub] Add pull request template (#151) bd7830b [pcied] Remove unnecessary message and move the configuration path (#144) 9080fda [ci] Call pip2/3 using sudo (#150) de60784 [ci] Test and build packages using Azure Pipelines (#149) 8bf0fd1 [ledd] Refactor to allow for more thorough unit testing; Increase unit test coverage (#147) 26bdc9e Set up CI with Azure Pipelines 1fcaa57 [pcied] Add PCIe AER stats collection (#100) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
- What I did
Fix fan control bug that causes segmentation fault when system P/N is not recognized by it.
Update the following component P/N of F2B airflow models:
- How I did it
Handle the case when system P/N is not recognized by set fan speed to max and exit the program.
Add error log about unrecognize P/N in the system log.
- How to verify it
Change System P/N in TLV EEPROM to something else like "EMPTY" or remove P/N feild.
Then run
service fanctrl restart
the fand_v2 MUST not crash.An error about unrecognized system P/N logged in the system log.
- Description for the changelog
Fix questone2db fancontrol app crash
Test log: