Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor/#56] 폰트 프리로드 #57

Merged
merged 2 commits into from
Nov 29, 2024
Merged

[Refactor/#56] 폰트 프리로드 #57

merged 2 commits into from
Nov 29, 2024

Conversation

imddoy
Copy link
Collaborator

@imddoy imddoy commented Nov 27, 2024

📌 관련 이슈번호

🎟️ PR 유형

어떤 변경 사항이 있나요?

  • 새 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 리팩토링

✅ Key Changes

이번 PR에서 작업한 내용을 간략히 설명해주세요

  1. 폰트 적용이 너무 느려서 메인화면 카드 padding 계산이 첫 로딩할 때는 잘 되지 않아서 preload하도록 했습니다.

📢 To Reviewers

  • 혹시 싫으신가여...?

📸 스크린샷

🔗 참고 자료

@imddoy imddoy self-assigned this Nov 27, 2024
Copy link
Member

@gwagjiug gwagjiug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

폰트 적용 속도가 렌더링 속도를 못따라잡아서 첫 화면에서 padding이 적용안돼서 preload로 폰트 우선순위를 강제했다는 말씀이시죠?

어차피 메인화면에 다른 리소스요청은 많이 없을 것 같아서 괜찮을 것 같아요~! 좋습니다~

Copy link
Collaborator

@youtheyeon youtheyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

신기한 방법이네요 어푸푸

@imddoy imddoy merged commit 8407c62 into develop Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Refactor ] 폰트 프리로드
3 participants