[Feat/#60] 메인 페이지 뉴스 조회 API 연결 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwagjiug
approved these changes
Nov 29, 2024
| @@ -2,7 +2,6 @@ import axios from 'axios'; | |||
|
|
|||
| export const instance = axios.create({ | |||
| baseURL: import.meta.env.VITE_API_BASE_URL, | |||
| withCredentials: true, | |||
There was a problem hiding this comment.
로그인 토큰 넣을 때 필요한데, 이번 합세에서는 헤더에 넣는 요청들이 없더라구요! 그래서 지웠습니다...ㅎ
| try { | ||
| const response: AxiosResponse<getNewsResponse> = await get('/news'); | ||
| const response: AxiosResponse<getNewsResponse> = await get( | ||
| `/news${cursor ? `?cursor=${cursor}` : ''}`, |
| queryFn: () => getNews(cursor), | ||
| staleTime: 1000 * 60 * 60, | ||
| gcTime: 1000 * 60 * 60 * 12, | ||
| retry: 3, |
There was a problem hiding this comment.
이 쿼리 세팅 값들은 그냥 보편적으로 사용되는 세팅값인가요? 아니면 고려하고 설정한게 있나요?? 궁금해서 여쭤보는 것...
There was a problem hiding this comment.
개발자가 쿼리마다 적절하게 지정해주는 것으로 알고 있습니다!!
저는 이렇게 지정해준 이유는, 맥도날드 홍보용 카드뉴스(?)는 사실 올라오는 주기가 그렇게 많지도 않고 한번 올라왔을 때 수정이 발생하지 않는다고 생각했습니다.
그래서 1시간 정도를 staletime으로 주어도 괜찮을 것 같다고 판단했고, staleTime보다 gcTime이 길게 설정되어야 하고, 적절한 시간을 고민하다가 12시간으로 설정해두었습니다!
| @@ -48,6 +48,7 @@ export const TitleStyle = (isThreeLines: boolean) => (theme: Theme) => css` | |||
| color: ${theme.colors.gray500}; | |||
| ${theme.fonts.title07}; | |||
| overflow: auto; | |||
| word-break: keep-all; | |||
youtheyeon
approved these changes
Nov 29, 2024
|
|
||
| color: transparent; | ||
| ${theme.fonts.title07}; | ||
| overflow: auto; | ||
| } | ||
|
|
||
| p::after { | ||
| content: ''; | ||
| content: 'dd'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
✅ Key Changes
📢 To Reviewers
📸 스크린샷
🔗 참고 자료