Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to send mails to case, contact, event participant and travel entry persons [5] #12463

Closed
10 tasks done
Tracked by #12402
SORMAS-ChristopherMeyer opened this issue Aug 29, 2023 · 2 comments · Fixed by #12770 or #12789
Closed
10 tasks done
Tracked by #12402
Assignees
Labels
backend Affects the web backend email-templates feature A new feature to be developed (ticket type) lu Adaptations requested by or implemented for Luxembourg qa-verified Issue has been tested and verified by QA ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application

Comments

@SORMAS-ChristopherMeyer
Copy link

SORMAS-ChristopherMeyer commented Aug 29, 2023

Feature Description

Add a new "Emails" side component to cases, contacts, event participants and travel entries, and allow users to send emails based on email templates to the associated person.

Added Value/Benefit

Users will be able to send external emails through SORMAS without having to go through an external email client and having to manually fill in information all the time.

Acceptance Criteria

  • A new "Emails" side component has been added to cases, contacts, event participants and travel entries
  • A "Send email" button has been added to the component
  • When the associated person has no email address specified, a hint is displayed in the component: "Case/contact/event participant/travel entry person has no email address specified" and the button is disabled
  • Clicking on the button brings up a popup that allows the user to configure and send the email:
    • A "Choose template" dropdown contains all email templates for the respective entity and allows the user to choose one
    • An "Email address" dropdown contains the primary email address and, if available, all additional email addresses from the person contact details entities associated with the person
    • The primary email address is selected by default and has a (primary) suffix; this suffix is translatable through i18n
    • The user can close the popup with a "Discard" button, or send the email with a "Send" button; when the send button is clicked and the template or email address dropdowns are empty, show an error notification and tell the user to select an email template and an email address
  • The new components are only visible for users with the EXTERNAL_EMAIL_SEND user right introduced in Create new user rights to manage, send and attach documents to email templates [0.5] #12466 and when the new EXTERNAL_EMAILS feature type introduced in View existing and create new email templates in the configuration screen [5] #12461 is enabled
  • It's verified that emails sent this way are actually sent

Implementation Details

Mockups

image
image

Additional Information

Password protection and document attachment will be handled in separate issues.

@SORMAS-ChristopherMeyer SORMAS-ChristopherMeyer added feature A new feature to be developed (ticket type) lu Adaptations requested by or implemented for Luxembourg labels Aug 29, 2023
@MateStrysewske MateStrysewske added ready Issue fulfills the definition of ready and can be implemented email-templates backend Affects the web backend vaadin-app Affects the Vaadin application labels Oct 30, 2023
@MateStrysewske MateStrysewske changed the title Possibility to select email templates in the UI Allow users to send mails to case, contact, event participant and travel entry persons Oct 30, 2023
@MateStrysewske MateStrysewske changed the title Allow users to send mails to case, contact, event participant and travel entry persons Allow users to send mails to case, contact, event participant and travel entry persons [5] Nov 9, 2023
@leventegal-she leventegal-she self-assigned this Nov 16, 2023
leventegal-she pushed a commit that referenced this issue Nov 21, 2023
leventegal-she pushed a commit that referenced this issue Nov 22, 2023
…and travel entry persons - add missing @AuditedClass annotation
leventegal-she pushed a commit that referenced this issue Nov 23, 2023
…and travel entry persons - fixed failing test
leventegal-she pushed a commit that referenced this issue Nov 23, 2023
…and travel entry persons - added missing translations
sergiupacurariu added a commit that referenced this issue Nov 23, 2023
sergiupacurariu added a commit that referenced this issue Nov 23, 2023
…mail-from-case-contact-ep-te

#12463 Allow users to send mails to case, contact, event participant …
@adinaflorea9 adinaflorea9 self-assigned this Nov 23, 2023
@adinaflorea9
Copy link

adinaflorea9 commented Nov 28, 2023

I am reopening the ticket due to the following:

  • event participant page - email missing hint has a spelling error (two words are stuck together);

  • when only non-primary email address exists - the default selection in the email dropdown just shows (primary) - should either show nothing or one of the other email addresses (just showing primary could confuse the user to think that it means they are using the primary email address when in fact it is missing);

  • the warning message in the above situation should also be updated to say the name of the field as it is displayed in the UI and not the one from the code (appears when clicking send but in the email dropdown only the word primary is displayed);

  • for users restricted by jurisdiction - if the entity is not owned, outside jurisdiction the button and card is enabled but sending can not be done as the information is confidential - card should be disabled if responsible or disease jurisdiction do not match the user and they do not have ownership over the entity.

@adinaflorea9 adinaflorea9 reopened this Nov 28, 2023
leventegal-she pushed a commit that referenced this issue Nov 28, 2023
…and travel entry persons - fixed ui issues
sergiupacurariu added a commit that referenced this issue Nov 29, 2023
…ues-found-by-qa

#12463 Allow users to send mails to case, contact, event participant …
@adinaflorea9
Copy link

Verified ticket on the local machine using the latest version of SORMAS from the development branch - 1.92.0-SNAPSHOT(a10d1df).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Affects the web backend email-templates feature A new feature to be developed (ticket type) lu Adaptations requested by or implemented for Luxembourg qa-verified Issue has been tested and verified by QA ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application
Projects
None yet
4 participants