Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor modification for the new Gmsh example #1205

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

mnagaso
Copy link

@mnagaso mnagaso commented Feb 20, 2024

As following the instruction in the last PR
#1204 (comment)

I modified:

  • the name of example directory
  • use the nummaterial_velocity_file

Thank you very much for your feedback and merging this PR.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b735263) 54.64% compared to head (998f97e) 53.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1205      +/-   ##
==========================================
- Coverage   54.64%   53.22%   -1.42%     
==========================================
  Files         164      164              
  Lines       30233    30084     -149     
==========================================
- Hits        16520    16012     -508     
- Misses      13713    14072     +359     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielpeter danielpeter merged commit 3ed3fd0 into SPECFEM:devel Feb 21, 2024
29 of 31 checks passed
@mnagaso
Copy link
Author

mnagaso commented Feb 21, 2024

Thank you very much for pointing out the problem! I will modify it very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants