fix one error in compute_forces_acoustic.f90

[xiezhinan]

--error with using LDDRK in acoustic simulation with PML
--modify one variable name in specfem2D.F90 with changing rmemory_potential_acoust_LDDRK to rmemory_potential_acoustic_LDDRK

This modification will generate different results if compared with Robot, since I have fix one error.

[komatits]

Hi all,

We should accept / merge this one without buildbot because the
seismograms will purposely be slightly different (slightly better)

Dimitri.

On 12/05/2013 05:14 PM, Xie Zhinan wrote:

--error with using LDDRK in acoustic simulation with PML
--modify one variable name in specfem2D.F90 with changing
rmemory_potential_acoust_LDDRK to rmemory_potential_acoustic_LDDRK

This modification will generate different results if compared with
Robot, since I have fix one error.

---

    You can merge this Pull Request by running

git pull https://github.com/xiezhinan/specfem2d devel

Or view, comment on, or merge it at:

#3

    Commit Summary

• fix one error in compute_forces_acoustic.f90

  File Changes
  

• M src/specfem2D/compute_forces_acoustic.f90
  https://github.com/geodynamics/specfem2d/pull/3/files#diff-0 (51)

• M src/specfem2D/specfem2D.F90
  https://github.com/geodynamics/specfem2d/pull/3/files#diff-1 (14)

  Patch Links:
  

• https://github.com/geodynamics/specfem2d/pull/3.patch

• https://github.com/geodynamics/specfem2d/pull/3.diff

Dimitri Komatitsch
CNRS Research Director (DR CNRS), Laboratory of Mechanics and Acoustics,
UPR 7051, Marseille, France http://komatitsch.free.fr

[komatits]

PS: please let us know if/how we need to accept/approve it.

Thanks,
Dimitri.

On 12/05/2013 05:18 PM, Dimitri Komatitsch wrote:

Hi all,

We should accept / merge this one without buildbot because the
seismograms will purposely be slightly different (slightly better)

Dimitri.

On 12/05/2013 05:14 PM, Xie Zhinan wrote:

--error with using LDDRK in acoustic simulation with PML
--modify one variable name in specfem2D.F90 with changing
rmemory_potential_acoust_LDDRK to rmemory_potential_acoustic_LDDRK

This modification will generate different results if compared with
Robot, since I have fix one error.

---

    You can merge this Pull Request by running

git pull https://github.com/xiezhinan/specfem2d devel

Or view, comment on, or merge it at:

#3

    Commit Summary

• fix one error in compute_forces_acoustic.f90

  File Changes
  

• M src/specfem2D/compute_forces_acoustic.f90
  https://github.com/geodynamics/specfem2d/pull/3/files#diff-0 (51)

• M src/specfem2D/specfem2D.F90
  https://github.com/geodynamics/specfem2d/pull/3/files#diff-1 (14)

  Patch Links:
  

• https://github.com/geodynamics/specfem2d/pull/3.patch

• https://github.com/geodynamics/specfem2d/pull/3.diff

Dimitri Komatitsch
CNRS Research Director (DR CNRS), Laboratory of Mechanics and Acoustics,
UPR 7051, Marseille, France http://komatitsch.free.fr

[xiezhinan]

Hi all,

It is safe to accept it.
Since I have tested with examples before commit.

Best regards,
Zhinan

[mpbl]

Dimitri,

You have rights to do it.
On pull request pages, you have a button to do it via the web interface and also command line instructions.

[luet]

I will merge it into devel, should I merge it into the master as well?

[komatits]

Yes!

thanks
Dimitri

On 12/05/2013 05:31 PM, David Luet wrote:

I will merge it into devel, should I merge it into the master as well?

—
Reply to this email directly or view it on GitHub
#3 (comment).

Dimitri Komatitsch
CNRS Research Director (DR CNRS), Laboratory of Mechanics and Acoustics,
UPR 7051, Marseille, France http://komatitsch.free.fr

[komatits]

Thanks!
First time I use Git, thus I need to learn ;-)

Dimitri.

On 12/05/2013 05:30 PM, Matthieu Lefebvre wrote:

Dimitri,

You have rights to do it.
On pull request pages, you have a button to do it via the web interface
and command line instruction.

—
Reply to this email directly or view it on GitHub
#3 (comment)
Bug from
https://github.com/notifications/beacon/Sbn60wvBFpzzHmncfV7n1L6gftTPmql6O-PsgiVdwWHuRcQGiV1qTkP2fUpeOtzt.gif

Dimitri Komatitsch
CNRS Research Director (DR CNRS), Laboratory of Mechanics and Acoustics,
UPR 7051, Marseille, France http://komatitsch.free.fr