- added Brune and Smoothed Brune source time functions #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #1650 +/- ##
==========================================
- Coverage 51.51% 51.48% -0.03%
==========================================
Files 266 266
Lines 60104 60136 +32
==========================================
Hits 30961 30961
- Misses 29143 29175 +32 ☔ View full report in Codecov by Sentry. |
|
Your Brune function now looks correct. |
Thanks! |
danielpeter
reviewed
Nov 17, 2023
| ! This needs to be CHECKED!!! | ||
| t0 = min(t0,1.5d0 * (tshift_src(isource) - hdur(isource))) | ||
| case (6) | ||
| ! Smotthed Brune |
There was a problem hiding this comment.
just in case, "smoothed" not "smotthed"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented time derivatives of the Brune and smoothed Brune functions as the moment rate functions.
@jpampuero can you please check whether the implementation is correct?
@danielpeter m4/ and some DATA/ files are automatically changed, but I ignored them while pushing. Please check.
I think we need some tests for origin time. Some users are ready to test. If you have any suggestions, please let me know:)