- added USE_OTHER_TIME_FUNCTION in Par_file to implement the Brune and Smooth Brune functions for CMTSOLUTION #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Smooth Brune functions for CMTSOLUTION
|
I am fixing a bug :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my view, the best way to reconcile source time functions for CMTSOLUTION and FORCESOLUTION is to create a new common parameter for both CMTSOLUTION and FORCESOLUTION similar to:
SOURCE_TIME_FUNCTION = gaussian
and get rid of USE_RICKER_TIME_FUNCTION from the Par_file and "source time function" from the FORCESOLUTION.
However, to minimise the code changes, I have added a new parameter, USE_OTHER_TIME_FUNCTION, for now. Currently, it is implemented only for the viscoelastic simulations, and the available other functions are Brune and Smooth Brune.