Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hdf5 update #1738

Merged
merged 8 commits into from
Sep 16, 2024
Merged

Hdf5 update #1738

merged 8 commits into from
Sep 16, 2024

Conversation

mnagaso
Copy link
Contributor

@mnagaso mnagaso commented Sep 12, 2024

I created logical H5_COL flag in shared_param to control the IO mode of HDF5 easily (collective or independent). This is useful for the case that the machine does not like collective I/O (TACC Frontera).
I also modified the file write process of neighbors_adjncy in generate_databases to use 64-bit integer so that the code allows to count the number of the array elements which is larger than the maximum of 32 bit integer.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 50.68%. Comparing base (1b0d98c) to head (d1d0415).
Report is 17 commits behind head on devel.

Files with missing lines Patch % Lines
src/shared/check_mesh_resolution.f90 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1738      +/-   ##
==========================================
- Coverage   50.92%   50.68%   -0.25%     
==========================================
  Files         270      271       +1     
  Lines       61506    61801     +295     
==========================================
  Hits        31322    31322              
- Misses      30184    30479     +295     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnagaso
Copy link
Contributor Author

mnagaso commented Sep 14, 2024

Probably some other arrays' length need to be counted with integer(kind=8) for a large size mesh.

@danielpeter danielpeter merged commit 809e5d3 into SPECFEM:devel Sep 16, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants