Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct number of decimal places for postgresql annotation of invoices #13

Open
thor opened this issue Nov 21, 2017 · 1 comment
Open

Correct number of decimal places for postgresql annotation of invoices #13

thor opened this issue Nov 21, 2017 · 1 comment
Labels
bug help wanted minor
Milestone
next

Comments

@thor
Copy link
Member

thor commented Nov 21, 2017 •
edited
Loading

This involves either rounding the invoices data when it multiplied with each other, or using the Python format tools to correct it.

Initially I used

models.DecimalField(decimal_places=2)

which didn't help, oddly enough on postgres, which has been changed to

models.DecimalField()

in 2e17503 for the meanwhile. These details can be seen in spbm/apps/society/models.py.
@thor thor changed the title Correct costs for postgresql Correct number of decimal places for postgresql annotation of invoices Nov 21, 2017
thor added a commit that referenced this issue Nov 21, 2017
@thor
Tries to do something with #13
6c7edef 
Firstly adds back decimal_places, with great hope, but also rewrites the
annotation to have both an event_cost and a total_cost.
thor added a commit that referenced this issue Nov 21, 2017
@thor
Using decimal_places=2 for unpaid invoices too
7232a22 
This did not help for #13 on the remote instance; some further debugging
is required, sadly.
@thor
Copy link
Member Author

thor commented Mar 5, 2018

Seeing as I've tried to fix this myself, and somewhat failed (let's be honest here), this is more of a help wanted situation.

@thor thor added this to the next milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted minor
Projects
None yet
Milestone
next
Development

No branches or pull requests
1 participant
@thor