Refactor fargate profile to only create securitygrouppolicy optionally, and create it part of fargate EKS cluster deployment #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y, and create it part of fargate EKS cluster deployment
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+89
to
+104
| data "aws_iam_policy_document" "fargate_logging" { | ||
| #checkov:skip=CKV_AWS_111:Restricted to Cloudwatch Actions only | ||
| #checkov:skip=CKV_AWS_356: Only logs actions | ||
| statement { | ||
| sid = "" | ||
| effect = "Allow" | ||
| resources = ["*"] | ||
|
|
||
| actions = [ | ||
| "logs:CreateLogStream", | ||
| "logs:CreateLogGroup", | ||
| "logs:DescribeLogStreams", | ||
| "logs:PutLogEvents", | ||
| ] | ||
| } | ||
| } |
Check warning
Code scanning / checkov
Ensure no IAM policies documents allow "*" as a statement's resource for restrictable actions
Comment on lines
+89
to
+104
| data "aws_iam_policy_document" "fargate_logging" { | ||
| #checkov:skip=CKV_AWS_111:Restricted to Cloudwatch Actions only | ||
| #checkov:skip=CKV_AWS_356: Only logs actions | ||
| statement { | ||
| sid = "" | ||
| effect = "Allow" | ||
| resources = ["*"] | ||
|
|
||
| actions = [ | ||
| "logs:CreateLogStream", | ||
| "logs:CreateLogGroup", | ||
| "logs:DescribeLogStreams", | ||
| "logs:PutLogEvents", | ||
| ] | ||
| } | ||
| } |
Check warning
Code scanning / checkov
Ensure IAM policies does not allow write access without constraints
niroz89
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix fargate logger not having permissions to write logs to cloudtrail