Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable types #1

Merged
merged 7 commits into from
Jun 23, 2022
Merged

Conversation

lawliet89
Copy link

No description provided.

lawliet89 and others added 6 commits March 11, 2022 11:48
- Annotations/labels can only be `map(string)`
- Make Webhook Ingress Hosts more flexible
Co-authored-by: James (Anh-Tu) Nguyen <tunguyen9889@users.noreply.github.com>
Comment on lines 12 to 13
checkov_skip_check: CKV2_AWS_23
skip_precommit: terraform-validate,tflint
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think we can remove these also for this ? we need to add helmlint in our workflow sooner.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just copied the files over without checking.

Copy link

@niroz89 niroz89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lawliet89 Let me merge this first.

@niroz89 niroz89 merged commit 3d157d2 into SPHTech-Platform:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants