Fix kubernetes manifest #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawliet89
reviewed
Sep 8, 2022
|
|
||
| metadata = { | ||
| name = "${lower(each.value.name)}-runner-deployment" | ||
| namespace = var.chart_namespace |
There was a problem hiding this comment.
Why don't we stick with this and change this to
namespace = helm_release.namespace
?
Then there will be an implicit dependency.
There was a problem hiding this comment.
Yea it should work let me test it, Thanks
|
The dependency is not fixed, it's a known limitation CRD must exist before CR creation, detailed discussion:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends_onnot working withkubernetes_manifestits an open issueas a workaround we can use
kubectl_manifesthttps://medium.com/@danieljimgarcia/dont-use-the-terraform-kubernetes-manifest-resource-6c7ff4fe629a