-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/#5 mypage screen구현 #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "feat/#5-mypage-screen\uAD6C\uD604"
Changes from all commits
05fd336
190bab1
5323665
c0b39c6
cd5920f
73f8568
0417943
bee42bc
53b5c88
e094464
728a11c
bd64edd
5815904
08f17ca
c0e613e
3a01eef
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:width="33dp" | ||
| android:height="33dp" | ||
| android:viewportWidth="33" | ||
| android:viewportHeight="33"> | ||
| <path | ||
| android:pathData="M16.5,2.75C24.094,2.75 30.25,8.907 30.25,16.5C30.25,24.093 24.094,30.25 16.5,30.25C8.906,30.25 2.75,24.093 2.75,16.5C2.75,8.907 8.906,2.75 16.5,2.75ZM16.5,5.042C10.182,5.042 5.042,10.182 5.042,16.5C5.042,22.818 10.182,27.958 16.5,27.958C22.818,27.958 27.958,22.818 27.958,16.5C27.958,10.182 22.818,5.042 16.5,5.042ZM16.499,19.94C16.863,19.94 17.212,20.085 17.47,20.343C17.728,20.6 17.872,20.95 17.872,21.314C17.872,21.678 17.728,22.028 17.47,22.285C17.212,22.543 16.863,22.688 16.499,22.688C16.134,22.688 15.785,22.543 15.527,22.285C15.27,22.028 15.125,21.678 15.125,21.314C15.125,20.95 15.27,20.6 15.527,20.343C15.785,20.085 16.134,19.94 16.499,19.94ZM16.492,9.625C16.741,9.625 16.982,9.715 17.17,9.879C17.358,10.042 17.481,10.269 17.515,10.516L17.524,10.655L17.53,16.845C17.53,17.107 17.431,17.358 17.253,17.549C17.075,17.741 16.83,17.857 16.57,17.875C16.309,17.893 16.051,17.811 15.848,17.646C15.645,17.482 15.513,17.246 15.477,16.987L15.467,16.847L15.462,10.658C15.462,10.522 15.488,10.388 15.54,10.263C15.592,10.137 15.668,10.023 15.763,9.928C15.859,9.832 15.973,9.756 16.098,9.704C16.223,9.652 16.356,9.625 16.492,9.625Z" | ||
| android:fillColor="#F34343"/> | ||
| </vector> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,8 +63,8 @@ enum class StudyTheme( | |
| OTHER("기타"); | ||
|
|
||
| companion object { | ||
| fun from(value: String): StudyTheme? = | ||
| values().firstOrNull { it.name == value } | ||
| fun from(value: String): StudyTheme = | ||
| StudyTheme.entries.first { it.name == value } | ||
|
Comment on lines
+66
to
+67
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: cat core/model/src/main/java/com/umcspot/spot/model/Global.kt | head -120Repository: SPOTeam/Android-V2 Length of output: 2292 🏁 Script executed: # Search for all calls to StudyTheme.from()
rg -n "StudyTheme\.from" --type=kt -C3Repository: SPOTeam/Android-V2 Length of output: 88 🏁 Script executed: # Check SocialLoginType.from() for comparison
rg -n "SocialLoginType\.from" --type=kt -A5Repository: SPOTeam/Android-V2 Length of output: 88 🏁 Script executed: rg -n "StudyTheme\.from" -C3Repository: SPOTeam/Android-V2 Length of output: 693 🏁 Script executed: # Also search for any try-catch blocks around StudyTheme.from
rg -n "StudyTheme\.from" -C5Repository: SPOTeam/Android-V2 Length of output: 903 🏁 Script executed: # Search in all kotlin files
fd "\.kt$" | xargs grep -n "StudyTheme.from" -C3Repository: SPOTeam/Android-V2 Length of output: 693 🏁 Script executed: # Search for all StudyTheme.from occurrences (ensure we found them all)
rg "StudyTheme\.from"Repository: SPOTeam/Android-V2 Length of output: 189 🏁 Script executed: # Look at UserPreferredCategoryResponseDto definition to understand data source
fd "UserPreferredCategoryResponseDto" | head -5Repository: SPOTeam/Android-V2 Length of output: 156 🏁 Script executed: # Find and examine the DTO definition
rg -n "UserPreferredCategoryResponseDto" --type=kotlin | head -10Repository: SPOTeam/Android-V2 Length of output: 1440 🏁 Script executed: # Search in all files for UserPreferredCategoryResponseDto
fd "\." | xargs grep -l "UserPreferredCategoryResponseDto" 2>/dev/null | head -5Repository: SPOTeam/Android-V2 Length of output: 450 🏁 Script executed: cat data/user/src/main/java/com/umcspot/spot/user/dto/response/UserPreferredCategoryResponseDto.ktRepository: SPOTeam/Android-V2 Length of output: 446 🏁 Script executed: # Check the mapping function context
cat data/user/src/main/java/com/umcspot/spot/user/mapper/UserMapper.kt | head -70Repository: SPOTeam/Android-V2 Length of output: 2282 🏁 Script executed: # Check if there's any error handling at the service/repository level
rg -n "getUserPreferredCategory|toDomain" data/user/src/main/java/com/umcspot/spot/user/service/ -A5 -B5Repository: SPOTeam/Android-V2 Length of output: 1178 API 응답 매핑 시 런타임 크래시 위험
같은 파일의 🔧 안전한 기본값 반환 제안 companion object {
- fun from(value: String): StudyTheme =
- StudyTheme.entries.first { it.name == value }
+ fun from(value: String): StudyTheme =
+ StudyTheme.entries.firstOrNull { it.name == value } ?: OTHER
}🤖 Prompt for AI Agents |
||
| } | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -45,6 +45,9 @@ data class Study ( | |||||||||||||||||||||
| @SerialName("isOwner") | ||||||||||||||||||||||
| val isOwner: Boolean, | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| @SerialName("isAlone") | ||||||||||||||||||||||
| val isAlone: Boolean, | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| @SerialName("hitCount") | ||||||||||||||||||||||
| val hitCount: Int = 0, | ||||||||||||||||||||||
|
Comment on lines
+48
to
52
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 역호환을 위해 기본값 추가 필요 🛠 제안 수정 `@SerialName`("isAlone")
- val isAlone: Boolean,
+ val isAlone: Boolean = false,📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||
|
|
||||||||||||||||||||||
|
|
||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Color.Unspecified사용 시 이미지가 보이지 않는 버그painterTint의 기본값이Color.Unspecified일 때ColorFilter.tint()를 적용하면 이미지가 투명하게 렌더링되어 보이지 않습니다.Color.Unspecified는 내부적으로0x00000000값을 가지므로, tint 필터가 이미지를 사실상 숨기게 됩니다.🐛 colorFilter 조건부 적용 제안
Image( painter = painter, contentDescription = null, modifier = Modifier .size(screenWidthDp(33.dp)), - colorFilter = ColorFilter.tint(painterTint) + colorFilter = if (painterTint != Color.Unspecified) ColorFilter.tint(painterTint) else null )📝 Committable suggestion
🤖 Prompt for AI Agents