Skip to content

[LAB1] 511558013 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 17, 2024
Merged

[LAB1] 511558013 #3

merged 11 commits into from
Mar 17, 2024

Conversation

forbis
Copy link

@forbis forbis commented Mar 6, 2024

Description

Update main_test.js and pass validate.sh at local.


  • A clear title (name your PR "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing all CI

finish lab1
@forbis forbis changed the title [lab1]511558013 [LAB1]511558013 Mar 6, 2024
@TaiYou-TW TaiYou-TW added the lab1 label Mar 6, 2024
@forbis forbis changed the title [LAB1]511558013 [LAB1] 511558013 Mar 6, 2024
@TaiYou-TW
Copy link
Contributor

@forbis Sorry for the inconvenience. However, you should re-sync the branch under your repo to fix permission problem to run CI workflows.

@forbis forbis closed this Mar 13, 2024
@TaiYou-TW
Copy link
Contributor

You shouldn't close this PR because we nedd to grade your lab1 submission.

@forbis
Copy link
Author

forbis commented Mar 14, 2024

Should I close lab2 PR and reopen lab1 PR?

@forbis forbis reopened this Mar 14, 2024
@AlaRduTP AlaRduTP merged commit 2e671aa into SQLab:511558013 Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants