-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor actions script #132
Conversation
- master | ||
paths: | ||
- '.github/workflows/test-install-script.yml' | ||
- 'wall_e_install.sh' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed
- master | ||
paths: | ||
- '.github/workflows/test-install-script.yml' | ||
- 'wall_e_install.sh' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed
include: | ||
- name: MacOS-latest | ||
host_runner: macos-latest | ||
package_manager: brew |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed
paths: | ||
- '.github/workflows/test-install-script.yml' | ||
- 'wall_e_install.sh' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be removed
paths: | ||
- '.github/workflows/test-install-script.yml' | ||
- 'wall_e_install.sh' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be removed
@Jamm02 the installation fails on macOS check this https://github.com/SRA-VJTI/Wall-E/actions/runs/3951413427/jobs/6765234345#step:3:58220 |
Add at the top of walle_install.sh set -e Exit immediately if a pipeline (see Pipelines), which may consist of a single simple command (see Simple Commands), a list (see Lists of Commands), or a compound command (see Compound Commands) returns a non-zero status. |
Installer fails for Ubuntu as well https://github.com/SRA-VJTI/Wall-E/actions/runs/3951413427/jobs/6765234345#step:4:17 |
Define a _sudo(){
if ! command -v sudo &> /dev/null
then
if ! [ $(id -u) = 0 ]; then
echo "The script need to be run as root." >&2
exit 1
fi
"$@"
else
sudo "$@"
fi
} Replace |
wall_e_install.sh
Outdated
@@ -27,7 +27,6 @@ unameOut="$(uname -s)" | |||
case "${unameOut}" in | |||
Linux*) | |||
_sudo apt update && _sudo apt upgrade -y | |||
_sudo usermod -a -G dialout $USER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of removing, try double quoting the "$USER"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was intended to be removed (#117) so that participants would be exposed to enabling port access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, sorry use [ ! -z "${USER}" ] && _sudo usermod -a -G dialout "$USER"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not know that
_sudo apt update && _sudo apt upgrade -y | ||
_sudo apt install git wget flex bison gperf python3 python3-pip python3-setuptools cmake ninja-build ccache libffi-dev libssl-dev dfu-util libusb-1.0-0 -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export DEBIAN_FRONTEND=noninteractive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and then do apt stuff
MacOs has issues due to a python 11 package. Ref - espressif/esp-idf#10116 (comment) |
No description provided.