Support Multi-Attribute Strings #6
Conversation
Add list of methods and explain how to build an AttributedString with various attributes at ranges
Clarify default of clearsAttributesOnNextString
| public func setAttribute(attribute: NSAttributedStringAttribute) { | ||
| // Builder functions | ||
|
|
||
| public func setAttribute(attribute: NSAttributedStringAttribute) throws { |
There was a problem hiding this comment.
Can you explain why this function throws?
|
A++ PR 👍 Unit tests on Jenkins appear to be failing. One failure is related to the addition of If you can get those passing, and add additional coverage for the new methods we should be good to go 👍 Great job For the tests, you'll want to run them on the iPhone 6 iOS 9.0 simulator because of SnapShot test consistency. You should add a SnapShot test for your new addition, they are really easy and fun to write! Do let me know if you need any help getting started, there are some current tests in Thanks again! |
|
@gregpardo Just wanted to bump as I got a little side tracked and forgot about this! Everything looks super great here, if you resolve those couple of CR notes you are good to merge! I'll pull you in as a contributor to the repo :-D Thanks again for the great work |
No description provided.