Add tuple bind and executeMany #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRombauts
reviewed
May 19, 2019
|
I did not test this at all yet, so I guess it should work, but I definetly need to write a unit test for these functions aswell and add some comments. However when there is already something you would do in a different way feel free to comment on it ;) |
|
@SRombauts I added test cases, comments and fixed a few broken things, so now it should be ready for review and integration |
|
@SRombauts little reminder :) |
|
Thank you very much for this contribution! I was very busy recently (releasing a pre alpha version of a game) but I will try to also review and merge the few other interesting PR waiting. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the option to use a tuple with values to bind.
I will use this to implement executeMany as described in #24, so it will be possible to pass multiple tuples
I only created this PR, so the CI already tests this, since I still need to implement executemany and add some tests