CMakeLists.txt: use transitive compile definitions via cmake #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds transitive compile definitions via cmake. When this PR is used, a slightly more "modern" syntax is employed for the compile defines
SQLITE_ENABLE_COLUMN_METADATA
,SQLITECPP_ENABLE_ASSERT_HANDLER
, andSQLITE_USE_LEGACY_STRUCT
. With this more modern syntax, its possible to specify for every flag aPUBLIC
orPRIVATE
visibility. WithPUBLIC
visibility (currently the default in this PR), downstream projects also have access to the flags.This can be specifically helpful for
SQLITE_ENABLE_COLUMN_METADATA
, which downstream projects can use to tweak their code at compile time.Please feel free to change the visibility of the individual flags. The previous default (before this PR) was
PRIVATE
visibility for all three flags.