Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficiency splitted #242

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Conversation

KOLANICH
Copy link
Contributor

Splitted #241 even further. Should be a bit more reviewable what I have done than when collapsed into a single commit. Though it is not yet fully usable, let's try to troubleshhot step-by-step.

@KOLANICH KOLANICH changed the title Efficiency 1 Efficiency splitted Dec 25, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 96.444% when pulling b98eabb on KOLANICH:efficiency_1 into 11fab0f on SRombauts:master.

@SRombauts
Copy link
Owner

Hello @KOLANICH thank you very much for splitting your changes!

This one is very good indeed: I was actually starting to work on a similar refactor this morning when I was remembered of it.

After this get in, please don't hesitate to rebase/retarget your other pull request so that we can have some more in. Basically I am only looking at a PR seriously when it passes all checks (which can lead to some wasted like this one).

Cheers!

@SRombauts SRombauts merged commit cb421a8 into SRombauts:master Jan 9, 2020
@KOLANICH
Copy link
Contributor Author

Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants