Windows improved support (meson) #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using long long may be ambigous for the compiler in the call of bind() using a fixed type(int64_t) solves this issue this issue was replicated on both Arch Linux&Windows with clang 13.0.1/14.0.1
define NON_AMBIGOUS_OVERLOAD to prevent ambiguous overload and use int instead of long to prevent ambiguous overload errors
on windows may show an error in xstddef if c++11 is used this is a workarround for that issue "deduced return types are a C++14 extension"
make the meson file link statically the library when building the unit tests executable so it does not fail on windows as the symbols are not exported by default
|
Thanks a lot for this contribution. Cheers! |
SRombauts
added a commit
that referenced
this pull request
Aug 30, 2023
this PR only affects meson, however a later change could be made for CMake updates the following depenencies: - GTests to 1.14.0 - sqlite to 3.42.0 makes sets the recommended version to C++14 as Gtest now requires C++14, additionally shows a warning and sets it to c++14 if - C++11 is set and is on windows (this was #354 but now checks if is C++11 and shows a warning instead of setting it to C++14 so it does not revert when using a newer version) - C++11 is set and uses [GTest 1.14.0](https://github.com/google/googletest/releases/tag/v1.14.0) or greater, for more information check [Google's Foundational C++ Support Policy](https://opensource.google/documentation/policies/cplusplus-support)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is an improvement of #352, managing to compile statically and run unit tests successfully on windows.
a summary of the changes in this PR:
the library still does not compile dynamically (as windows does not export the functions by default), so that should be fixed on an 3rd PR potentially fixing #280 and #53 for both meson and cmake, but this is a start before working on adding a macro for that feature.
after the dynamic compilation on windows is fixed, we could put the package on wrapdb so more users can use it easily.