Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements and code cleaning #360

Merged
merged 9 commits into from
Sep 18, 2022
Merged

Small improvements and code cleaning #360

merged 9 commits into from
Sep 18, 2022

Conversation

Kacperos155
Copy link
Contributor

@Kacperos155 Kacperos155 commented Jul 23, 2022 •
edited
Loading

  • std::unique_ptr in Backup
  • Database::tryExec(const std::string) changed to Database::tryExec(const std::string&)
  • Backup::getRemainingPageCount() and Backup::getTotalPageCount() are now const
  • Database::tableExists() and Database::getHeaderInfo() are now const
  • Transparent comparator (std::less) in Statement::mColumnNames to avoid creating std::string when comparing

@SRombauts SRombauts self-assigned this Jul 24, 2022
SRombauts
SRombauts requested changes Jul 24, 2022
View reviewed changes
Copy link
Owner

@SRombauts SRombauts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice changes, thanks for this!

Could you please have a look at my comments?

Cheers!

include/SQLiteCpp/Backup.h Outdated Show resolved Hide resolved
src/Backup.cpp Outdated Show resolved Hide resolved
include/SQLiteCpp/Backup.h Outdated Show resolved Hide resolved
include/SQLiteCpp/Savepoint.h Outdated Show resolved Hide resolved
include/SQLiteCpp/Transaction.h Outdated Show resolved Hide resolved
@Kacperos155
Copy link
Contributor Author

I made the changes required in the review 😸

@Kacperos155 Kacperos155 requested a review from SRombauts July 24, 2022 17:09
@Kacperos155
Copy link
Contributor Author

I had rebased branch to new commits on master to resolve conflicts

@SRombauts SRombauts merged commit c7cffad into SRombauts:master Sep 18, 2022
@SRombauts
Copy link
Owner

Thanks for your contribution :)
I am now releasing all this as part of version 3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SRombauts SRombauts SRombauts requested changes

Assignees

@SRombauts SRombauts

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kacperos155 @SRombauts