-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meson] fixes for meson project #380
Conversation
this macro is no longer needed for the tests as part of the cleanup in commit 091726a
I have a local patch here I've been meaning to send to make a meson install match a cmake install. I guess most meson users are just bundling/wrapping rather than installing. Feel free to include in your future PR if you want since you're working on that area.
|
thanks for the notice! edit: also set the subdir to SQliteCpp |
I didn't even notice it was missing from the compile/test lists. Mea culpa. Not a problem, no rush.
CMake just copies all the headers from the directory during install. I'm fairly sure I did side-by-side installs into dummy paths and than compared to see which files were missing.
|
You can install the whole directory with Meson too: install_subdir('include/SQliteCpp', install_dir: get_option('includedir')) |
I think we can use the second option of installing the subdir, so we don´t need to keep track of the files but let users choose if they want to install them thanks for the replies! |
use install_subdir instead of the install_headers in the meson config file
added the missing example 2 executable |
as dynamic linking is not supported on windows we can give a warning and compile the library as static itself
Thanks a lot for the outstanding teamwork, reviews, and patches :) |
I think it's also time to release a new version, probably just a patch 3.2.1, that will come with all the little cleanup & build system update that already accumulated. |
sure, since Meson support on Windows is already good, we can also set it as the first version in Meson Wrapdb. |
PR Description
This PR does the following things.
.cache
directory created by vscode when using clangd3.2.0
if there is anything else required please let me know
Future aditions on another PR
meson wrap install sqlitecpp
, this is out of scope for this repo, but should be done once the dynamic windows support is ready.If there is anything else missing please let me know