Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make std::filesystem optional #388

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

UnixY2K
Copy link
Contributor

@UnixY2K UnixY2K commented Dec 11, 2022

Description

Add a switch to disable std::filesystem so it can be disabled if required on older compilers, this should let users that older compilers versions to disable it, solving #378 for meson and cmake, additionally checks in the source code if the header is found

changes

  • CMakeLists.txt: adds a new option that is disabled by default
  • Database.h
    • adds an additional check for <filesystem> and <experimental/filesystem>
    • checks for the previous switch and disables the support if enabled
  • meson.build/meson.options adds the same option that disables std::filesystem support

I think this PR should be made on 3.2.1 or greater as is a new feature/enhancement itself and should come with the other planned project cleanups, please let me know if there is anything else required

Add a switch to disable std::filesystem so it can be optinally disabled
this should let users that older compilers versions to disable it
@UnixY2K UnixY2K closed this Dec 11, 2022
@UnixY2K UnixY2K deleted the std-filesystem-optional branch December 11, 2022 21:31
@UnixY2K UnixY2K restored the std-filesystem-optional branch December 11, 2022 21:35
@UnixY2K
Copy link
Contributor Author

UnixY2K commented Dec 11, 2022

closed by mistake

@UnixY2K UnixY2K reopened this Dec 11, 2022
@SRombauts SRombauts self-assigned this Dec 11, 2022
@SRombauts SRombauts merged commit 8e00fef into SRombauts:master Dec 11, 2022
@SRombauts
Copy link
Owner

Thanks!
And yes I agree, this should be released as part of 3.2.1, which I plan to release tomorrow if all goes well.

Sadly, there were no CI/CD checks on this PR, I think because it was closed (or I missed something else?) so I'll have to check status on master post-merge.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants