check if SQLITE_OPEN_NOFOLLOW is defined #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
under MacOS 11 BigSur(macos-latest) the macro SQLITE_OPEN_NOFOLLOW is not defined so it may cause compilation issues for those versions
This was referenced Dec 14, 2022
Merged
|
Hey, thanks for this. I agree that it's strange, and I didn't want to rush it yesterday, but it cannot do any harm after all :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
under MacOS 11 BigSur(
macos-latest) the macroSQLITE_OPEN_NOFOLLOWis not defined so it may cause compilation issues for those versions, you can check more about it on this repo which extracts it: https://github.com/ninjaoflight/macos-latest-checksthis seems to be an edge case as the sqlite version on that image is reported as
3036000but does not adds it, I don´t know if this issue is related to only the MacOS GitHub Image, however this should also fix those edge corners where this modification is present.this was noticed under the meson review, so this could be added on a separate parch under wrapdb, which has not been merged as this issue is present, however this should not been an issue for any future CI run as
mac-os latestwill be MacOS 12 Montereyplease let me know if there is anything else required