Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mismatched else condition in CMakeLists.txt #415

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

Timmmm
Copy link
Contributor

@Timmmm Timmmm commented Apr 11, 2023

From the CMake docs:

Per legacy, the else() and endif() commands admit an optional argument. If used, it must be a verbatim repeat of the argument of the opening if command.

Doesn't really matter but it could be confusing to people who aren't very familiar with CMake's intricacies. Also it triggers an annoying lint warning in my IDE.

From the CMake docs:

> Per legacy, the else() and endif() commands admit an optional <condition> argument. If used, it must be a verbatim repeat of the argument of the opening if command.
@SRombauts SRombauts merged commit 39070b2 into SRombauts:master Apr 11, 2023
@SRombauts
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants