Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLiteCpp/Statement.h: add missing <cstdint> include #488

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Sep 7, 2024

Without the change the build fails on gcc-15 as:

[  5%] Building CXX object CMakeFiles/SQLiteCpp.dir/src/Backup.cpp.o
In file included from /build/source/include/SQLiteCpp/Column.h:14,
                 from /build/source/include/SQLiteCpp/Database.h:14,
                 from /build/source/include/SQLiteCpp/Backup.h:15,
                 from /build/source/src/Backup.cpp:12:
/build/source/include/SQLiteCpp/Statement.h:132:39: error: 'uint32_t' does not name a type
  132 |     void bind(const int aIndex, const uint32_t      aValue);
      |                                       ^~~~~~~~
/build/source/include/SQLiteCpp/Statement.h:20:1: note: 'uint32_t' is defined in header '<cstdint>'; this is probably fixable by adding '#include <cstdint>'
   19 | #include <memory>
  +++ |+#include <cstdint>
   20 |

Without the change the build fails on `gcc-15` as:

    [  5%] Building CXX object CMakeFiles/SQLiteCpp.dir/src/Backup.cpp.o
    In file included from /build/source/include/SQLiteCpp/Column.h:14,
                     from /build/source/include/SQLiteCpp/Database.h:14,
                     from /build/source/include/SQLiteCpp/Backup.h:15,
                     from /build/source/src/Backup.cpp:12:
    /build/source/include/SQLiteCpp/Statement.h:132:39: error: 'uint32_t' does not name a type
      132 |     void bind(const int aIndex, const uint32_t      aValue);
          |                                       ^~~~~~~~
    /build/source/include/SQLiteCpp/Statement.h:20:1: note: 'uint32_t' is defined in header '<cstdint>'; this is probably fixable by adding '#include <cstdint>'
       19 | #include <memory>
      +++ |+#include <cstdint>
       20 |
@SRombauts SRombauts self-assigned this Sep 7, 2024
@SRombauts SRombauts merged commit 643b153 into SRombauts:master Sep 7, 2024
18 checks passed
@SRombauts
Copy link
Owner

Thanks a lot for taking the time to contribute these two fixes, much appreciated

@trofi trofi deleted the gcc-15-add-cstdint branch September 7, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants