-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface for restarts #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
😎 Merged successfully (details). |
pabloferz
force-pushed
the
restarts
branch
3 times, most recently
from
February 28, 2023 21:57
3a5a313
to
b6f7150
Compare
gustavor101
requested changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The restart functionality works well with pickle files and multiple calls in notebooks, but a couple of examples could be useful for the user like showing that the loggers are now incorporated in SamplingContext and not in pysages.run as before.
Closed
InnocentBug
previously approved these changes
Apr 18, 2023
Add a restart example for the restart interface.
gustavor101
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two ways of restarting runs:
From a stored
Result
(this is compatible with our MPI interface). One change introduced here is that the last snapshot of a simulation is now also part ofResult
instances. The interface looks likepysages.run(result: Result, context_generator: Callable, timesteps: int, *other_args, **kwargs)
(that is, one would switch
method
byresult
when restarting).From a
SamplingContext
(which is a renaming of ourContextWrapper
). This is useful for interactive sessions, say in a jupyter notebook, or for debugging purposes.FFS is left out for now as it is too different and requires other changes to its interface.