Added a looping autoplay to the Story page. #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @wes977, thanks for this! Since it's just a repo quality update, I'll merge into master right away |
quinnlangille
pushed a commit
that referenced
this pull request
Oct 31, 2018
|
@quinnlangille is this new feature add to the last release |
|
Hey @yashwanth1796, this isn't a new feature - it just adds an example for out already existing loop functionality. You can see the new example in the projects vue-play environment |
MartinGerritsen
pushed a commit
to MartinGerritsen/vue-carousel
that referenced
this pull request
Nov 16, 2018
quinnlangille
pushed a commit
that referenced
this pull request
Nov 26, 2018
quinnlangille
added a commit
that referenced
this pull request
Nov 29, 2018
* feat(standard): adding touchDrag prop to block touch dragging (#296) * feat(standard): adding touchDrag prop to block dragging on mobile devices * feat(standard): adding touchDrag prop to block dragging on mobile devices - removing package-lock.json * adding line-break space to end of file * chore(build): release for rc1 * v0.16.0-rc1 * Fix carousel failing to lock to remainder slides (#303) * Update Carousel.vue fix carousel bug * Added a looping autoplay to the Story page. (#305) * docs(readme): updated README configuration section (#304) * v0.16.0-rc2 * fix: rename event slideClick to slideclick in Slide.vue (#311) * fix: rename event slideClick to slideclick * fix(slide): disable tap highlight in Mobile Safari (#326) * fix(slide): disable tap highlight in Mobile Safari * feat: add correct calculation for pageCount (#329) * chore: build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a story on how to have the autoplay loop when on the last slide.
Description
used the loop prop so that it goes to the first slide after the last slide.
as referenced in issue #288
Motivation and Context
Displays how you can make the carousel infinitely loop-able.
#288 Issue
How Has This Been Tested?
Ran the tests, also went through the different tabs on the story to make sure that they ll act the same post change.
Screenshots (if appropriate):
Types of changes
Checklist: