Use vue-test-utils for testing #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephting
commented
Dec 3, 2018
This was referenced Dec 3, 2018
Merged
|
Great work @josephting. The PR review form really show us how little tests we have, so super glad you're taking on this initiative. I'll wait for a response from @ashleysimpson on your comment re: snapshots, but otherwise looks good |
josephting
force-pushed
the
feat/test-utils
branch
from
63ab003 to
7cd7e57
Compare
|
Thank you, @quinnlangille. This PR is ready to be merged now. Then, we can have #337 merged as well. |
|
Great! Will merge into the working branch now, really great work @josephting 🚀 |
quinnlangille
pushed a commit
that referenced
this pull request
Dec 19, 2018
quinnlangille
pushed a commit
that referenced
this pull request
Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vue-test-utilsto package.jsonvue-test-utilsretaining the original method used in each of the tests.I have noticed some tests aren't doing anything while other does not generate exact same snapshot but those fixes will come later.
Motivation and Context
Effort being placed in so that work on increasing code coverage can eventually be carried out for the project.
How Has This Been Tested?
.notor removing.notto test if they can failprecommitpassed as beforeScreenshots (if appropriate):
N/A
Types of changes
Bug fix (non-breaking change which fixes an issue)Breaking change (fix or feature that would cause existing functionality to not work as expected)Checklist:
My change requires a change to the documentation.I have updated the documentation accordingly.I have included a vue-play example (if this is a new feature)Todo:
should apply 200px carousel width when element has 200px widthtest case (currently, it does not fail even after adding.notto the assertion)