Update Navigation Buttons CSS #598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous css transform was making the buttons go off screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the css transform property for the navigation buttons by eliminating translateX for both VueCarousel-navigation-prev and VueCarousel-navigation-next classes.
Motivation and Context
I was looking for a solution why using :navigationEnabled="true" wasn't working for me and found this issue.
The issue is marked as closed but it seems the proposed solution didn't solve the whole problem for some people (read comments after closing).
After tweaking a bit I found the original css was moving the navigation buttons off the screen and removing the translateX solved it.
How Has This Been Tested?
Tested by hand.
Screenshots (if appropriate):
Types of changes
Checklist: