-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
several fixes #57
several fixes #57
Conversation
6a1dc85
to
a2ac31a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to change .travis.yml and I wonder how tests succeeded :/
hmm, indeed, |
@SSPkrolik @yglukhov I tested locally (based on output from https://travis-ci.com/timotheecour/nimongo/jobs/159187423) , it turns out travis.yml is buggy, can we please merge this and figure out travis after?
|
@SSPkrolik @yglukhov in a future PR, we should make travis run |
/cc @yglukhov I added some commits ; lemme know if u want these in another PR |
ping |
@timotheecour thanks a lot for the contribution! |
/cc @yglukhov @SSPkrolik
nimble test
should run test suite #54EDIT
nimble test
,nimble test_ci
commands to test with or without mongod