Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Mobile | Social media fixes #1088

Merged
merged 3 commits into from
Oct 16, 2024
Merged

🐛 Mobile | Social media fixes #1088

merged 3 commits into from
Oct 16, 2024

Conversation

zacharykeeping
Copy link
Member

@zacharykeeping zacharykeeping commented Oct 16, 2024 •
edited
Loading

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Closes #1087

  1. What was changed?
  1. Fixes setting the cursor position to the end when tapping the field in the social media popup.
  2. Updates the social media popups to load existing data when opened from the Settings page.

✅ Figure: Social media popups now show existing data

  1. Did you do pair or mob programming?

No

matt-goldman-ssw
matt-goldman-ssw approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@matt-goldman-ssw matt-goldman-ssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharykeeping zacharykeeping merged commit 068c07b into main Oct 16, 2024
6 checks passed
@zacharykeeping zacharykeeping deleted the social-media-fix branch October 16, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-goldman-ssw matt-goldman-ssw matt-goldman-ssw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Mobile | Social Media issues
2 participants
@zacharykeeping @matt-goldman-ssw