Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Mobile | Top Bar fixes #1089

Merged
merged 1 commit into from
Oct 16, 2024
Merged

🐛 Mobile | Top Bar fixes #1089

merged 1 commit into from
Oct 16, 2024

Conversation

zacharykeeping
Copy link
Member

@zacharykeeping zacharykeeping commented Oct 16, 2024

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Testing

  1. What was changed?
  1. Implements a proper workaround on iOS for the gap that appears above our custom top bar. We previously worked around this by setting a negative Y translation on the top bar on iOS but this gap can change between devices (such as the latest iPhone 16 models which have an increased gap). This change fills the gap with our Background colour for all gap sizes so our top bar template can work generically.
  2. Fixes an issue where title text in the top bar can be off-centre.

✅ Figure: There are no gaps above the top bar when the Y translation is removed

✅ Figure: Title text is now correctly vertically centred

  1. Did you do pair or mob programming?

No

Copy link
Contributor

@matt-goldman-ssw matt-goldman-ssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a little dirty - having this in AppShell. Happy to merge now but consider adding an issue to investigating whether this can be handled in the platform folder.

@zacharykeeping
Copy link
Member Author

This feels a little dirty - having this in AppShell. Happy to merge now but consider adding an issue to investigating whether this can be handled in the platform folder.

Thanks - I can look into this.

I've created a PBI for this here: #1090

@zacharykeeping zacharykeeping merged commit ce2d6f6 into main Oct 16, 2024
6 checks passed
@zacharykeeping zacharykeeping deleted the top-bar-fix branch October 16, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants