Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 UI - Profile Page #237

Merged
merged 16 commits into from
May 31, 2022
Merged

V2 UI - Profile Page #237

merged 16 commits into from
May 31, 2022

Conversation

matt-goldman
Copy link
Contributor

@matt-goldman matt-goldman commented May 31, 2022

This PR completes the layout for the profile page and the new app shell structure. There are also associated API changes.

This is WIP but is already a monster PR. I wanted to merge this now before it grows even more out of control.

Video here: https://youtu.be/xmfIheKW_kc

(I have no idea why my video framerate is so bad. We won't send this live anyway, we'll do that when the new UI is complete).

TODO:

  • Profile badge icons
  • Admin portal for activity type
  • Admin portal for achievement type
  • Improve algorithm for mapping staff to achievements
  • Remove duplicate staff achievements

Copy link
Member

@lukecookssw lukecookssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy PR, Batman!
Great work - app looks killer

Copy link
Contributor

@william-liebenberg william-liebenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matt-goldman matt-goldman merged commit 78724b6 into master May 31, 2022
@matt-goldman matt-goldman deleted the v2-ui branch May 31, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants