Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to quiz functionality in mobile app #549

Merged
merged 9 commits into from
Jan 2, 2024
Merged

Conversation

zacharykeeping
Copy link
Member

@zacharykeeping zacharykeeping commented Dec 18, 2023

#504

Fixes up various issues with the quiz functionality in the app as it currently stands (is still disabled):

  1. Fixes various layout issues with items misaligned, overlapping or rendering outside the viewport.
  2. Adjusts layout to better use available space.
  3. Fixes display of radio buttons on dark background.
  4. Fixes Next button being displayed as Submit when first launching a quiz on iOS.
  5. Fixes previous quiz being shown when entering another quiz.
  6. Fixes crashes when moving between quizzes.

Simulator Screenshot - iPhone 15 Pro Max - 2023-12-18 at 14 25 42

Figure: Quiz page (note: Quizzes button at bottom only temporary and not included in this PR)

Simulator Screenshot - iPhone 15 Pro Max - 2023-12-18 at 14 25 53

Figure: Quiz details page (note: Quizzes button at bottom only temporary and not included in this PR)

@zacharykeeping zacharykeeping marked this pull request as ready for review December 18, 2023 04:36
@matt-goldman
Copy link
Contributor

Have you tested these changes across different platforms and device sizes?

@zacharykeeping
Copy link
Member Author

Have you tested these changes across different platforms and device sizes?

Yeah on iOS and Android at different sizes, smallest being iPhone SE. Seems to all look and work okay.

There's probably more that can be done here but this should hopefully fix up the obvious issues I encountered.

Simulator Screenshot - iPhone SE (3rd generation) - 2023-12-19 at 09 11 44

Figure: Quiz page on iPhone SE

Simulator Screenshot - iPhone SE (3rd generation) - 2023-12-19 at 09 11 50

Figure: Quiz details page on iPhone SE

@tkapa
Copy link
Member

tkapa commented Dec 20, 2023

Hey Zach!

I've pulled and tested these changes, and they seem cool so far!

As per our conversation, I've found a few bugs that should be addressed before we merge:

  • Swiping backwards through the Quiz doesn't move the "Progress" bar backwards. (only once you get the "Incomplete Quiz" popup)
  • Should we have a back button? The swiping doesn't seem as Intuitive (optional)
  • The GitHub Quiz is having problems submitting
  • The API does not take the Pass/Fail state of the quiz correctly, when you fail a quiz, it is marked as complete in the app.
  • When I failed the Angular Quiz, and moved back to the Quiz Page to try another Quiz, I saw the "Quiz Failed" page.
  • Some answers reference "B and C" but aren't lettered in the App :P

Copy link
Contributor

@matt-goldman matt-goldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharykeeping zacharykeeping merged commit ebc3d2f into main Jan 2, 2024
1 check passed
@zacharykeeping zacharykeeping deleted the quiz-fixes branch January 2, 2024 22:35
@AntPolkanov AntPolkanov mentioned this pull request Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants