Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SQL administrators to separate resource #586

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

matt-goldman
Copy link
Contributor

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ Fixes #585

  1. What was changed?

✏️ The SQL server administrators were moved out of direct assignment within the SQL Server resource in the bicep template, and added as their own resource with the SQL server set as the parent.

  1. Did you do pair or mob programming?

✏️ N/A

Copy link
Contributor

@william-liebenberg william-liebenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍄

Copy link
Member

@GordonBeeming GordonBeeming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛳️

@matt-goldman matt-goldman merged commit ba6a3e4 into main Jan 17, 2024
6 checks passed
@matt-goldman matt-goldman deleted the fix-sql-deployment branch January 17, 2024 02:25
@matt-goldman matt-goldman mentioned this pull request Jan 17, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Cannot deploy bicep for Azure SQL
3 participants