Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do you handle multi os dev teams #9566

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Do you handle multi os dev teams #9566

wants to merge 7 commits into from

Conversation

tomek-i
Copy link
Member

@tomek-i tomek-i commented Nov 7, 2024 •
edited
Loading

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ BizCover client work
SSWConsulting/SSW.SAW.General#4

  1. What was changed?

✏️ created new rule

  1. Did you do pair or mob programming (list names)?

✏️🥷🏻

@tomek-i tomek-i mentioned this pull request Nov 7, 2024
Open
@tomek-i tomek-i changed the title Create rule.md Do you handle multi os dev teams Nov 7, 2024
@github-actions github-actions bot added Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Nov 8, 2024
@github-actions github-actions bot added Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Nov 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

Howzit @tomek-i,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@github-actions github-actions bot added Age: 🦖 - Extinct About 128 hours old and removed Age: 🍗 - Ancient About 64 hours old labels Nov 10, 2024
danielmackay
danielmackay requested changes Nov 11, 2024
View reviewed changes
Copy link
Member

@danielmackay danielmackay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

rules/do-you-handle-multi-os-dev-teams-in-source-control/rule.md

```text
* text=auto
*.cs text eol=lf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right for *.cs files. We shouldn't have any specific configuration. I agree with the settings for *.sh and *.bat.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even for *.cs files I am getting Visual Studio always popping up with the file ending has changed do you want overwrite it? and that is usually when our MacOS people touched a file :-D

I can take it out though, let me know

rules/do-you-handle-multi-os-dev-teams-in-source-control/rule.md Outdated Show resolved Hide resolved
rules/do-you-handle-multi-os-dev-teams-in-source-control/rule.md

---

## Handling .NET secrets across platforms
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think secrets has anything to do with git configuration. Consider removing this section.

Copy link
Member Author

@tomek-i tomek-i Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has nothing to do with git configuration. It has a lot to do with multi os dev teams as mac users will mostly VS code for development and they have to manually set the secrets via command line while in VStudio you can use the context menu on the project in the IDE. (not sure about rider)

As most people will be using VStudio and then write the documentation targeting this IDE they need to figure out the command - it is much better practice in the onboarding documentation to just write the specific command that the devs can copy and paste.

rules/do-you-handle-multi-os-dev-teams-in-source-control/rule.md Outdated Show resolved Hide resolved
rules/do-you-handle-multi-os-dev-teams-in-source-control/rule.md Outdated Show resolved Hide resolved
danielmackay
danielmackay requested changes Nov 11, 2024
View reviewed changes
Copy link
Member

@danielmackay danielmackay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added another comment

rules/do-you-handle-multi-os-dev-teams-in-source-control/rule.md
related: []
created: 2024-11-05T12:52:08.000Z
archivedreason: null
guid: 7bc2e9c8-2b12-466b-8ecd-34576e3a1648
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule needs to be linked to a category.

Copy link
Member Author

@tomek-i tomek-i Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which category though?

tomek-i and others added 4 commits November 15, 2024 17:47
@tomek-i @tiagov8 @danielmackay
Apply suggestions from code review
b5b847a 
Co-authored-by: Tiago Araújo [SSW] <tiagov8@gmail.com>
Co-authored-by: Daniel Mackay [SSW] <2636640+danielmackay@users.noreply.github.com>
@tomek-i
Update rule.md
e8e3a23
@tomek-i
Merge branch 'do-you-handle-multi-os-dev-teams-in-source-control' of h…
8814d24 
…ttps://github.com/tomek-i/SSW.Rules.Content into do-you-handle-multi-os-dev-teams-in-source-control
@tomek-i
Update rule.md
7f7d1b8
tomek-i
tomek-i commented Nov 15, 2024
View reviewed changes
rules/do-you-handle-multi-os-dev-teams-in-source-control/rule.md Outdated Show resolved Hide resolved
rules/do-you-handle-multi-os-dev-teams-in-source-control/rule.md

---

## Handling .NET secrets across platforms
Copy link
Member Author

@tomek-i tomek-i Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has nothing to do with git configuration. It has a lot to do with multi os dev teams as mac users will mostly VS code for development and they have to manually set the secrets via command line while in VStudio you can use the context menu on the project in the IDE. (not sure about rider)

As most people will be using VStudio and then write the documentation targeting this IDE they need to figure out the command - it is much better practice in the onboarding documentation to just write the specific command that the devs can copy and paste.

rules/do-you-handle-multi-os-dev-teams-in-source-control/rule.md Outdated Show resolved Hide resolved
rules/do-you-handle-multi-os-dev-teams-in-source-control/rule.md Outdated Show resolved Hide resolved
rules/do-you-handle-multi-os-dev-teams-in-source-control/rule.md Outdated Show resolved Hide resolved
rules/do-you-handle-multi-os-dev-teams-in-source-control/rule.md Outdated Show resolved Hide resolved
rules/do-you-handle-multi-os-dev-teams-in-source-control/rule.md
related: []
created: 2024-11-05T12:52:08.000Z
archivedreason: null
guid: 7bc2e9c8-2b12-466b-8ecd-34576e3a1648
Copy link
Member Author

@tomek-i tomek-i Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which category though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagov8 tiagov8 tiagov8 requested changes

@danielmackay danielmackay danielmackay requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Age: 🦖 - Extinct About 128 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomek-i @danielmackay @tiagov8