Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fiducial #11

Open
wants to merge 69 commits into
base: master
Choose a base branch
from
Open

Fiducial #11

wants to merge 69 commits into from

Conversation

felipeaoli
Copy link
Contributor

Working in #6

@felipeaoli felipeaoli linked an issue Jun 22, 2023 that may be closed by this pull request
Add fiducials to standard run #6
Open
@felipeaoli
Copy link
Contributor Author

@felipeaoli , now it is necessary to use ~mask to isolate the spots from real positioners. In the future, I should do a 2d map of vblock positions

@felipeaoli felipeaoli added enhancement New feature or request wip Work in Progress (do not merge) labels Jun 22, 2023
felipeaoli and others added 22 commits June 22, 2023 16:22
@felipeaoli
adding new lib for fiducials
2a928fc
@felipeaoli
fix test
68a8c16
@felipeaoli
Proto library
9a70fa4
@felipeaoli
Adding fiducials to database
cc45522
@felipeaoli
ignoring spotfinder
c44daa4
@felipeaoli
adding mvlabel to fiducial database
bfbe85f
@felipeaoli @seanmacb
fixing small bugs
669b8fa
@felipeaoli @seanmacb
merging
d4ff76d
@felipeaoli
Merging
773c234
@felipeaoli
Merge branch 'fiducial' of https://github.com/SSantosLab/DESI-QA into…
74be7bb 
… fiducial
@felipeaoli
changing to branch mount
0c5db71
@felipeaoli
standalone tests for mount movement
1be24d2
@seanmacb
Merge branch 'fiducial' of https://github.com/SSantosLab/DESI-QA into…
d3a6cb4 
… fiducial
@felipeaoli
remove cem120 defaults
51d7dc3
@seanmacb
accomodating number of expected points
59ab2ec
@felipeaoli
documentation
daeb710
@felipeaoli
small tweaks in fid mask
f78087d
@seanmacb
debug of mount codes
cd9de6d
@seanmacb
debug of mount codes
cde811b
@seanmacb
fiducial database
8997533
@seanmacb
mounttable example
fc087d1
@felipeaoli
repeating n cycles
1ad17c0
felipeaoli and others added 19 commits June 29, 2023 00:46
@felipeaoli
trying to merge
34c4bb5
@felipeaoli
merging gitignore
2e564dc
@seanmacb
Adding logs file
1bb541f
@felipeaoli
Copying Sean's report
562a14a
@felipeaoli
Merge branch 'fiducial' of https://github.com/SSantosLab/DESI-QA into…
f2503c0 
… fiducial
@felipeaoli
change ddof
ea3dc19
@seanmacb
fixing stashed files, adding date capability to analysis
5ca22e5
@seanmacb
Updated figures for all phi and 10 iteration arctheta tests
abc59a9
@felipeaoli
plots for presentation
4c0d46f
@felipeaoli
Merge branch 'fiducial' of https://github.com/SSantosLab/DESI-QA into…
cb66ea9 
… fiducial
@felipeaoli
plots
dba973f
@seanmacb
phi backlash test in db, arctheta figures
2ca0672
@seanmacb
Merge branch 'fiducial' of https://github.com/SSantosLab/DESI-QA into…
053a218 
… fiducial
@seanmacb
Adding database to include second run of arcphi tests
500c905
@seanmacb
intial results of backlash test
03cddb6
@seanmacb
All backlash tests complete, databases updated
746e094
@seanmacb
pushing analysis notebooks
dd08953
@seanmacb
results from RS backlash tests - both motors around 2.2-2.3 degrees o…
6ea9f4d 
…f backlash
@seanmacb
Another arcphi test, no linphi observed
7c90640
@seanmacb seanmacb mentioned this pull request Jul 13, 2023
Open
@seanmacb
Copy link
Collaborator

@felipeaoli What do you think? Time to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request wip Work in Progress (do not merge)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add fiducials to standard run
2 participants
@felipeaoli @seanmacb