Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some rationale on interface choices:
.data()
or.cancel()
from the handler.dispatch_object_t
polymorphism internally to avoid public API changes.Some things that could be improved:
dispatch_walltime
times since there isn't a Rust interface fordispatch_time_t
yet.dispatch_source_set_event_handler
interface in the second commit as it's the only new symbol here not supported on most other distributions. Might want to use the samecfg
as QueueAttribute instead, or better, add library version detection to a build.rs.impl_source_type
macro doesn't save that much code.bitflags
and especiallylibc
dependencies aren't that big and could be removed if you want to retain zero dependencies.