Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mbox instead of malloc_buf #72

Closed
wants to merge 1 commit into from

Conversation

mehcode
Copy link
Contributor

@mehcode mehcode commented Aug 3, 2018

https://github.com/kennytm/mbox seems to have more 👀 on it then malloc_buf and given that this is a pretty niche area I think its worth it to switch. mbox also seems to have a nice extensive test suite too.

@SSheldon
Copy link
Owner

SSheldon commented Aug 5, 2018

I wasn't aware of mbox, thanks for bringing it up @mehcode! It does look nice, but since this is a breaking change so I'd like to hold off on merging it until the next major version of objc is being published.

Unfortunately I don't actually have a timeline for the next major version... I'd love for that version to just be 1.0 and batch together all possible breaking changes. objc is apparently directly depended on by 38 different crates now, so I want to minimize any fragmenting of the ecosystem.

Let me know if you think this is more urgent. On my end, it doesn't seem like mbox is very widely used (crates.io reports 0 crates depending on it), and while it does have lots of neat functionality, the objc crate doesn't need most of that.

@mehcode
Copy link
Contributor Author

mehcode commented Aug 5, 2018

My primary reason is mbox has an extensive test suite. Otherwise, no, there is no strong reasoning.

@madsmtm madsmtm mentioned this pull request Sep 5, 2021
80 tasks
@madsmtm madsmtm mentioned this pull request Nov 23, 2021
@mehcode mehcode closed this May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants