Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run rustfmt and require it in CI #96

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

madsmtm
Copy link

@madsmtm madsmtm commented May 27, 2021

The changes I've made can be seen here - the rest is done automatically by rustfmt

@madsmtm madsmtm marked this pull request as ready for review May 28, 2021 16:00
@madsmtm madsmtm mentioned this pull request Jun 3, 2021
@SSheldon
Copy link
Owner

SSheldon commented Aug 4, 2021

I'll be honest, I think rustfmt does some ugly things, so I'm not in any rush to do this. If there's a lot of changes being merged from multiple contributors, I think this makes sense. But as you can see that's not the case here because I am neglectful. I will keep this in mind to merge if development ramps back up here.

@madsmtm
Copy link
Author

madsmtm commented Aug 6, 2021

I agree that it's formatting is suboptimal, but it's better than nothing, and some things it definitely does better (like putting the explicit "C" on extern items, considering the maybe upcoming "C-unwind").

Which parts is it specifically that you have a gripe with? rustfmt's behaviour can easily be changed to suit your preferred style, see this.

But yeah, no rush on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants