Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing temporary variables that are going out of scope in Release build execution #1188

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixing temporary variables that are going out of scope in Release build execution #1188

wants to merge 4 commits into from

Conversation

khuck
Copy link
Contributor

@khuck khuck commented Jun 2, 2020 •
edited by hkaiser
Loading

see #1187

@khuck khuck mentioned this pull request Jun 2, 2020
Open
@hkaiser hkaiser changed the title Fixing temporary variables that are going out of scope in Release bui… Fixing temporary variables that are going out of scope in Release build execution Jun 2, 2020
@hkaiser hkaiser added this to the 0.0.1 milestone Jun 2, 2020
@hkaiser
Copy link
Member

hkaiser commented Jun 2, 2020

Are you sure those values returned from .tensor() went out of scope too early? The code here looks ok without your changes (but those shouldn't hurt in any way either).

@khuck
Copy link
Contributor Author

khuck commented Jun 2, 2020

Are you sure those values returned from .tensor() went out of scope too early? The code here looks ok without your changes (but those shouldn't hurt in any way either).

Honestly, because it's a Release build I couldn't get any info debugging. So I just made some assumptions. I am being a bit more disciplined with it now though - the debug build also fails with the assertion error, so I am replacing temporaries one at a time until I find the sweet spot between correct execution (no assertion error) and not crashing.

khuck added 2 commits June 2, 2020 11:22
@khuck
Cleaning up use of temporary varaibles
c41defe
@khuck
Merge branch 'fixing_1187' of github.com:STEllAR-GROUP/phylanx into f…
395e2e3 
…ixing_1187

Conflicts:
	src/plugins/keras_support/categorical_crossentropy_operation.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser Awaiting requested review from hkaiser

@stevenrbrandt stevenrbrandt Awaiting requested review from stevenrbrandt

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
category: PhySL type: enhancement
Projects
None yet
Milestone
0.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@khuck @hkaiser