Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csc hdf5 blaze #544

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

ct-clmsn
Copy link
Contributor

@ct-clmsn ct-clmsn commented Aug 1, 2018

attempt to provide csc-hdf5 storage support for blaze::CompressedMatrix<double, blaze::columnMajor> structures. used the h5sparse python library as a guidepost.

@ct-clmsn ct-clmsn added this to the 0.0.1 milestone Aug 1, 2018
@ct-clmsn ct-clmsn requested review from hkaiser and akheir August 1, 2018 02:26
@ct-clmsn
Copy link
Contributor Author

ct-clmsn commented Aug 1, 2018

i need to provide a unit test!

@ct-clmsn
Copy link
Contributor Author

ct-clmsn commented Aug 1, 2018

would it be possible to pass the variable's name as a string to this code as the hdf5 group name for the input matrix? this might be something the IR analyzer could do?

on 2nd thought, this might be/is a bad idea.

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ct-clmsn
Copy link
Contributor Author

ct-clmsn commented Aug 9, 2018

note: this PR fails to compile b/c it necessitates adding a new compressed/sparse type into the IR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants