case label value exceeds maximum value

[vincentfenet]

In lis2dux12_mode_get, looks like the last lines of this case are useless:

     case LIS2DUX12_TRIG_PIN:
     ^~~~
src/libs/LIS2DUX12/lis2dux12_reg.c:491:5: warning: case label value exceeds maximum value for type
     case LIS2DUX12_TRIG_SW:
     ^~~~```

[avisconti]

@vincentfenet Yes, it's a bug, thx. I'm going to do something like this:

    case 0xe:
      val->odr = LIS2DUX12_TRIG_PIN;
      break;
    case 0xf:
      val->odr = LIS2DUX12_TRIG_SW;
      break;

or the other possibility is to get rid of the extra nibble, which in this case it is useless (it is only usefule to distinguish same odr in LP and HP mode:

  LIS2DUX12_TRIG_PIN          = 0xE, /* Single-shot high latency by INT2 */
  LIS2DUX12_TRIG_SW           = 0xF, /* Single-shot high latency by IF */

what do you think?

[vincentfenet]

in the sourcecode:

switch (ctrl5.odr) 

with:

uint8_t odr : 4;

So I don't understand the point of LIS2DUX12_TRIG_PIN and LIS2DUX12_TRIG_SW. for me, this is dead code that need to be removed.

[avisconti]

in the sourcecode:

switch (ctrl5.odr) 

with:

uint8_t odr : 4;

So I don't understand the point of LIS2DUX12_TRIG_PIN and LIS2DUX12_TRIG_SW. for me, this is dead code that need to be removed.

Not sure I got your point. It's not dead code, but just possible values of

uint8_t odr : 4;

And they are 0xE (1110b) and 0xF (1111b).

Can you argument a bit more?

[vincentfenet]

yeah, sorry, it's not dead code.

1110 One-shot using the INT2 pin
1111 One-shot using the interface

so it looks like it's ok !

[avisconti]

yeah, sorry, it's not dead code.

1110 One-shot using the INT2 pin 1111 One-shot using the interface

so it looks like it's ok !

OK, thx for confirming. I just need to wait a bit before putting this change on GH, but I will.